third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js - Issue 2799603004: DevTools: Preserve source selection when using Quick Open

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

Issue 2799603004: DevTools: Preserve source selection when using Quick Open (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js b/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

index 0dc5924beda080eba2a369f900e9156e454d41b7..b2500fe92eca4a659a20393318f89fcf70a6f5be 100644

--- a/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

+++ b/third_party/WebKit/Source/devtools/front_end/sources/OpenFileQuickOpen.js

@@ -24,7 +24,10 @@ Sources.OpenFileQuickOpen = class extends Sources.FilteredUISourceCodeListProvid

if (!uiSourceCode)

return;

- Common.Revealer.reveal(uiSourceCode.uiLocation((lineNumber || 0), columnNumber));

+ if (typeof lineNumber === 'number')

+ Common.Revealer.reveal(uiSourceCode.uiLocation(lineNumber, columnNumber));

+ else

+ Common.Revealer.reveal(uiSourceCode);

}

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »