Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2799603003: dart2js: make dominator tree traversals nonrecursive (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -19 lines) Patch
M pkg/compiler/lib/src/ssa/nodes.dart View 1 1 chunk +61 lines, -13 lines 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
Meanwhile, I will hunt down the tests that should pass.
3 years, 8 months ago (2017-04-05 19:41:18 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2799603003/diff/1/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://codereview.chromium.org/2799603003/diff/1/pkg/compiler/lib/src/ssa/nodes.dart#newcode110 pkg/compiler/lib/src/ssa/nodes.dart:110: // void visitBasicBlockAndSuccessors(HBasicBlock block) { thank you for ...
3 years, 8 months ago (2017-04-05 19:56:37 UTC) #3
sra1
3 years, 8 months ago (2017-04-05 20:13:42 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f36aaa72a80b9ee49070a32d45433f6fccd1d405 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698