Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1212)

Side by Side Diff: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.js

Issue 2799563003: MD Settings: Move browserProxies outside of Polymer "properties". (Closed)
Patch Set: Address comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function() { 5 (function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * This is the absolute difference maintained between standard and 9 * This is the absolute difference maintained between standard and
10 * fixed-width font sizes. http://crbug.com/91922. 10 * fixed-width font sizes. http://crbug.com/91922.
(...skipping 29 matching lines...) Expand all
40 properties: { 40 properties: {
41 /** @private */ 41 /** @private */
42 advancedExtensionInstalled_: Boolean, 42 advancedExtensionInstalled_: Boolean,
43 43
44 /** @private */ 44 /** @private */
45 advancedExtensionSublabel_: String, 45 advancedExtensionSublabel_: String,
46 46
47 /** @private */ 47 /** @private */
48 advancedExtensionUrl_: String, 48 advancedExtensionUrl_: String,
49 49
50 /** @private {!settings.FontsBrowserProxy} */
51 browserProxy_: Object,
52
53 /** @private {!DropdownMenuOptionList} */ 50 /** @private {!DropdownMenuOptionList} */
54 fontOptions_: Object, 51 fontOptions_: Object,
55 52
56 /** @private */ 53 /** @private */
57 isGuest_: { 54 isGuest_: {
58 type: Boolean, 55 type: Boolean,
59 value: function() { return loadTimeData.getBoolean('isGuest'); } 56 value: function() { return loadTimeData.getBoolean('isGuest'); }
60 }, 57 },
61 58
62 /** 59 /**
(...skipping 22 matching lines...) Expand all
85 prefs: { 82 prefs: {
86 type: Object, 83 type: Object,
87 notify: true, 84 notify: true,
88 }, 85 },
89 }, 86 },
90 87
91 observers: [ 88 observers: [
92 'fontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)', 89 'fontSizeChanged_(prefs.webkit.webprefs.default_font_size.value)',
93 ], 90 ],
94 91
92 /** @private {?settings.FontsBrowserProxy} */
93 browserProxy_: null,
94
95 /** @override */ 95 /** @override */
96 created: function() { 96 created: function() {
97 this.browserProxy_ = settings.FontsBrowserProxyImpl.getInstance(); 97 this.browserProxy_ = settings.FontsBrowserProxyImpl.getInstance();
98 }, 98 },
99 99
100 /** @override */ 100 /** @override */
101 ready: function() { 101 ready: function() {
102 this.addWebUIListener('advanced-font-settings-installed', 102 this.addWebUIListener('advanced-font-settings-installed',
103 this.setAdvancedExtensionInstalled_.bind(this)); 103 this.setAdvancedExtensionInstalled_.bind(this));
104 this.browserProxy_.observeAdvancedFontExtensionAvailable(); 104 this.browserProxy_.observeAdvancedFontExtensionAvailable();
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 * Get the minimum font size, accounting for unset prefs. 159 * Get the minimum font size, accounting for unset prefs.
160 * @return {?} 160 * @return {?}
161 * @private 161 * @private
162 */ 162 */
163 computeMinimumFontSize_: function() { 163 computeMinimumFontSize_: function() {
164 return this.get('prefs.webkit.webprefs.minimum_font_size.value') || 164 return this.get('prefs.webkit.webprefs.minimum_font_size.value') ||
165 MINIMUM_FONT_SIZE_RANGE_[0]; 165 MINIMUM_FONT_SIZE_RANGE_[0];
166 }, 166 },
167 }); 167 });
168 })(); 168 })();
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698