third_party/WebKit/Source/web/ExternalPopupMenu.cpp - Issue 2799553002: Provide a std::vector compliant empty() method for WebVector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2799553002: Provide a std::vector compliant empty() method for WebVector. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

index c5b3466f234f940903ea4992b3c2b3147786907b..d8e0c51acd1880039b7ca1acedd0f7f67b7355d1 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp

@@ -84,7 +84,7 @@ bool ExternalPopupMenu::showInternal() {

WebPopupMenuInfo info;

getPopupMenuInfo(info, *m_ownerElement);

- if (info.items.isEmpty())

+ if (info.items.empty())

return false;

WebLocalFrameImpl* webframe =

WebLocalFrameImpl::fromFrame(m_localFrame.get());