Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2799503002: NOT FOR CHECKIN. Use Crashpad with --monitor-self (Closed)

Created:
3 years, 8 months ago by Mark Mentovai
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, jam, chromium-apps-reviews_chromium.org, net-reviews_chromium.org, darin-cc_chromium.org, mac-reviews_chromium.org, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT FOR CHECKIN. Use Crashpad with --monitor-self CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Now on https://codereview.chromium.org/2799013002

Patch Set 1 #

Patch Set 2 : Fix analyze failure #

Patch Set 3 : Fix analyze failure (2) #

Patch Set 4 : Do the probability stuff in crash_reporter_client implementations #

Patch Set 5 : Set ptype annotation from RunAsCrashpadHandler() #

Patch Set 6 : Move channel calculation to install_static #

Patch Set 7 : Remove obsolete #include #

Patch Set 8 : #include the right file #

Patch Set 9 : More gn analyze, one at a time #

Patch Set 10 : Introduce unnecessary assignment to quell C4701 #

Patch Set 11 : More C4701 #

Patch Set 12 : Rebase atop a4d005995302 #

Patch Set 13 : No more magic in RunAsCrashpadHandler() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -37 lines) Patch
M chrome/app/chrome_crash_reporter_client.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_mac.mm View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/app/chrome_exe_main_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/channel_info_win.cc View 1 2 3 4 5 2 chunks +1 line, -16 lines 0 comments Download
M chrome/install_static/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/install_static/DEPS View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/install_static/install_details.h View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/install_static/install_details.cc View 1 2 3 4 5 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome_elf/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M components/crash/content/app/crash_reporter_client.h View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M components/crash/content/app/crash_reporter_client.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M components/crash/content/app/crashpad_mac.mm View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M components/crash/content/app/crashpad_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +27 lines, -4 lines 0 comments Download
M components/crash/content/app/run_as_crashpad_handler_win.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -2 lines 0 comments Download
M components/crash/content/app/run_as_crashpad_handler_win.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +30 lines, -10 lines 0 comments Download
M components/version_info/BUILD.gn View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A components/version_info/channel.h View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
M components/version_info/version_info.h View 1 2 3 4 5 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 38 (38 generated)
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-04 21:29:55 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/1
3 years, 8 months ago (2017-04-04 21:30:43 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-04 21:38:37 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/241703) linux_android_rel_ng on ...
3 years, 8 months ago (2017-04-04 21:38:38 UTC) #4
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-04 21:42:32 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/20001
3 years, 8 months ago (2017-04-04 21:43:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-04 21:53:49 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/398163)
3 years, 8 months ago (2017-04-04 21:53:50 UTC) #8
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-04 22:00:25 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/40001
3 years, 8 months ago (2017-04-04 22:01:10 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-04 23:10:24 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/398182)
3 years, 8 months ago (2017-04-04 23:10:25 UTC) #12
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 00:16:14 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/60001
3 years, 8 months ago (2017-04-05 00:16:58 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-05 00:20:22 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/183892) ios-simulator-xcode-clang on ...
3 years, 8 months ago (2017-04-05 00:20:24 UTC) #16
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 02:57:06 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/100001
3 years, 8 months ago (2017-04-05 02:57:31 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-05 03:07:28 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/398417) win_clang on ...
3 years, 8 months ago (2017-04-05 03:07:29 UTC) #20
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 03:29:24 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/120001
3 years, 8 months ago (2017-04-05 03:29:46 UTC) #22
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 03:40:04 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/140001
3 years, 8 months ago (2017-04-05 03:40:23 UTC) #24
Mark Mentovai
Description was changed from ========== NOT FOR CHECKIN. Use Crashpad with --monitor-self ========== to ========== ...
3 years, 8 months ago (2017-04-05 03:51:33 UTC) #25
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 03:51:42 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/160001
3 years, 8 months ago (2017-04-05 03:52:00 UTC) #27
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 04:05:20 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/180001
3 years, 8 months ago (2017-04-05 04:05:41 UTC) #29
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 04:23:21 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/200001
3 years, 8 months ago (2017-04-05 04:23:31 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-05 05:38:16 UTC) #32
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-05 05:38:17 UTC) #33
Mark Mentovai
The CQ bit was checked by mark@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-05 16:49:45 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799503002/220001
3 years, 8 months ago (2017-04-05 16:50:04 UTC) #35
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-05 17:33:56 UTC) #36
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/355525)
3 years, 8 months ago (2017-04-05 17:33:57 UTC) #37
Mark Mentovai
3 years, 8 months ago (2017-04-05 18:39:22 UTC) #38 
Description was changed from

==========
NOT FOR CHECKIN. Use Crashpad with --monitor-self
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
==========

to

==========
NOT FOR CHECKIN. Use Crashpad with --monitor-self
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng

Now on https://codereview.chromium.org/2799013002
==========

Powered by Google App Engine
This is Rietveld 408576698