Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox.

chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
index d3fd9de3d1c930613dafdfa71934ab8cd54a431e..c5b339608f32739ec4444e83996043bb46ba5d01 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
@@ -427,10 +427,12 @@ Output.RULES = {
       speak: '$earcon(ALERT_MODAL) $name $nameOrTextContent $state $role'
     },
     cell: {

[David Tseng, 2017/04/11 03:48:09]

Also, I think you also want to modify the output rule for
table: {...}
for aria row and column count.

-      enter: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
-          '$node(tableColumnHeader)',
-      speak: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
-          '$node(tableColumnHeader) $state'
+      enter: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex,' +

[David Tseng, 2017/04/11 03:40:55]

Is the aria row index here possibly 0? $if would evaluate to false and pick the
third argument in that case.

Also,
nit: put each $if on its own line.

+      '$tableCellRowIndex), $if($ariaCellColumnIndex, $ariaCellColumnIndex,' +
+      '$tableCellColumnIndex)) $node(tableColumnHeader)',
+      speak: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex,' +
+      '$tableCellRowIndex), $if($ariaCellColumnIndex, $ariaCellColumnIndex,' +
+      '$tableCellColumnIndex)) $node(tableColumnHeader) $state'
     },
     checkBox: {
       speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
@@ -1251,6 +1253,13 @@ Output.prototype = {
           value = String(value + 1);
           options.annotation.push(token);
           this.append_(buff, value, options);
+          } else if (token == 'ariaCellRowIndex' ||

[David Tseng, 2017/04/11 03:40:55]

The $ prefix defaults to an attribute lookup so this isn't necessary.

+              token == 'ariaCellColumnIndex') {
+          var value = node[token];
+          if (value == undefined)

[David Tseng, 2017/04/11 03:40:55]

You don't need this if you're already using $if above.

+            return;
+          options.annotation.push(token);
+          this.append_(buff, value, options);
         } else if (token == 'node') {
           if (!tree.firstChild || !node[tree.firstChild.value])
             return;