Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox.

chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Provides output services for ChromeVox.
  */
 
 goog.provide('Output');
 goog.provide('Output.EventType');
@@ skipping 408 matching lines @@
           '$name $role $description $state'
     },
     alert: {
       enter: '$name $role $state',
       speak: '$earcon(ALERT_NONMODAL) $role $nameOrTextContent $state'
     },
     alertDialog: {
       enter: '$earcon(ALERT_MODAL) $name $state',
       speak: '$earcon(ALERT_MODAL) $name $nameOrTextContent $state $role'
     },
     cell: {

[David Tseng, 2017/04/11 03:48:09]

Also, I think you also want to modify the output rule for
table: {...}
for aria row and column count.

-      enter: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
-          '$node(tableColumnHeader)',
-      speak: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
-          '$node(tableColumnHeader) $state'
+      enter: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex,' +

[David Tseng, 2017/04/11 03:40:55]

Is the aria row index here possibly 0? $if would evaluate to false and pick the
third argument in that case.

Also,
nit: put each $if on its own line.

+      '$tableCellRowIndex), $if($ariaCellColumnIndex, $ariaCellColumnIndex,' +
+      '$tableCellColumnIndex)) $node(tableColumnHeader)',
+      speak: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex,' +
+      '$tableCellRowIndex), $if($ariaCellColumnIndex, $ariaCellColumnIndex,' +
+      '$tableCellColumnIndex)) $node(tableColumnHeader) $state'
     },
     checkBox: {
       speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
              '$name $role $checked $description $state'
     },
     client: {
       speak: '$name'
     },
     date: {
       enter: '$nameFromNode $role $description'
@@ skipping 800 matching lines @@
             msgId = msgId + '_brl';
           this.append_(buff, Msgs.getMsg(msgId), options);
         } else if (token == 'tableCellRowIndex' ||
             token == 'tableCellColumnIndex') {
           var value = node[token];
           if (value == undefined)
             return;
           value = String(value + 1);
           options.annotation.push(token);
           this.append_(buff, value, options);
+          } else if (token == 'ariaCellRowIndex' ||

[David Tseng, 2017/04/11 03:40:55]

The $ prefix defaults to an attribute lookup so this isn't necessary.

+              token == 'ariaCellColumnIndex') {
+          var value = node[token];
+          if (value == undefined)

[David Tseng, 2017/04/11 03:40:55]

You don't need this if you're already using $if above.

+            return;
+          options.annotation.push(token);
+          this.append_(buff, value, options);
         } else if (token == 'node') {
           if (!tree.firstChild || !node[tree.firstChild.value])
             return;
           var related = node[tree.firstChild.value];
           this.node_(related, related, Output.EventType.NAVIGATE, buff);
         } else if (token == 'nameOrTextContent') {
           if (node.name) {
             this.format_(node, '$name', buff);
           } else {
             var walker = new AutomationTreeWalker(node,
@@ skipping 613 matching lines @@
   /**
    * Gets the output buffer for braille.
    * @return {!Spannable}
    */
   get brailleOutputForTest() {
     return this.mergeBraille_(this.brailleBuffer_);
   }
 };
 
 });  // goog.scope