Implemented ARIA colindex, rowindex, colcount and rowcount for Chromevox.

chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Provides output services for ChromeVox.
  */
 
 goog.provide('Output');
 goog.provide('Output.EventType');
@@ skipping 409 matching lines @@
     },
     alert: {
       enter: '$name $role $state',
       speak: '$earcon(ALERT_NONMODAL) $role $nameOrTextContent $state'
     },
     alertDialog: {
       enter: '$earcon(ALERT_MODAL) $name $state',
       speak: '$earcon(ALERT_MODAL) $name $nameOrTextContent $state $role'
     },
     cell: {
-      enter: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
-          '$node(tableColumnHeader)',
-      speak: '@cell_summary($tableCellRowIndex, $tableCellColumnIndex) ' +
-          '$node(tableColumnHeader) $state'
+      enter: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex, ' +
+      '$tableCellRowIndex), ' +
+      '$if($ariaCellColumnIndex, $ariaCellColumnIndex, ' +
+      '$tableCellColumnIndex)) $node(tableColumnHeader)',
+      speak: '@cell_summary($if($ariaCellRowIndex, $ariaCellRowIndex, ' +
+      '$tableCellRowIndex), ' +
+      '$if($ariaCellColumnIndex, $ariaCellColumnIndex, ' +

[David Tseng, 2017/04/20 23:32:40]

Look at the way tableCellRowIndex/tableCellColumnIndex gets handled specially
below. (we explicitly add one to it so it's read correctly). Please do that for
the aria equivalents.

+      '$tableCellColumnIndex)) $node(tableColumnHeader) $state'
     },
     checkBox: {
       speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
              '$name $role $checked $description $state'
     },
     client: {
       speak: '$name'
     },
     date: {
       enter: '$nameFromNode $role $description'
@@ skipping 113 matching lines @@
     switch: {
       speak: '$if($checked, $earcon(CHECK_ON), $earcon(CHECK_OFF)) ' +
           '$if($checked, @describe_switch_on($name), ' +
           '@describe_switch_off($name)) $description $state'
     },
     tab: {
       speak: '@describe_tab($name) $state $description ' +
           '$if($setSize, @describe_index($posInSet, $setSize))',
     },
     table: {
-      enter: '@table_summary($name, $tableRowCount, $tableColumnCount) ' +
+      enter: '@table_summary($name, ' +
+          '$if($ariaRowCount, $ariaRowCount, $tableRowCount), ' +
+          '$if($ariaColumnCount, $ariaColumnCount, $tableColumnCount)) ' +
           '$node(tableHeader)'
     },
     tableHeaderContainer: {
       speak: '$nameOrTextContent $state $description'
     },
     textField: {
       speak: '$name $value $if($multiline, @tag_textarea, $if(' +
           '$inputType, $inputType, $role)) $description $state',
       braille: ''
     },
@@ skipping 669 matching lines @@
           this.append_(buff, msg || '', options);
         } else if (token == 'inputType') {
           if (!node.inputType)
             return;
           options.annotation.push(token);
           var msgId = Output.INPUT_TYPE_MESSAGE_IDS_[node.inputType] ||
               'input_type_text';
           if (this.formatOptions_.braille)
             msgId = msgId + '_brl';
           this.append_(buff, Msgs.getMsg(msgId), options);
         } else if (token == 'tableCellRowIndex' ||

[David Tseng, 2017/04/20 23:38:58]

Add checks for the aria prefixed TableCell*Index attributes here please. Thanks!

             token == 'tableCellColumnIndex') {
           var value = node[token];
           if (value == undefined)
             return;
           value = String(value + 1);
           options.annotation.push(token);
           this.append_(buff, value, options);
         } else if (token == 'node') {
           if (!tree.firstChild || !node[tree.firstChild.value])
             return;
@@ skipping 620 matching lines @@
   /**
    * Gets the output buffer for braille.
    * @return {!Spannable}
    */
   get brailleOutputForTest() {
     return this.mergeBraille_(this.brailleBuffer_);
   }
 };
 
 });  // goog.scope