Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2134)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Issue 2799423002: Deflake PageLoadMetricsBrowserTest.FirstMeaningfulPaintNotRecorded (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/page_load_metrics/page_with_active_connections.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
index aaa39991a87608ea1cbcdc178878c70b50a3b5b7..91db2be47df798828f6aeb965c343ee2fdc2dc28 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
@@ -665,8 +665,15 @@ IN_PROC_BROWSER_TEST_F(PageLoadMetricsBrowserTest,
FirstMeaningfulPaintNotRecorded) {
ASSERT_TRUE(embedded_test_server()->Start());
- ui_test_utils::NavigateToURL(browser(),
- embedded_test_server()->GetURL("/title1.html"));
+ scoped_refptr<TimingUpdatedObserver> fcp_observer =
+ CreateTimingUpdatedObserver();
+ fcp_observer->AddMatchingFields(
+ TimingUpdatedObserver::FIRST_CONTENTFUL_PAINT);
+
+ ui_test_utils::NavigateToURL(
+ browser(), embedded_test_server()->GetURL(
+ "/page_load_metrics/page_with_active_connections.html"));
+ fcp_observer->WaitForMatchingIPC();
// Navigate away before a FMP is reported.
NavigateToUntrackedUrl();
« no previous file with comments | « no previous file | chrome/test/data/page_load_metrics/page_with_active_connections.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698