Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2799403003: Use entities in JavaScriptBackendClasses (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use entities in JavaScriptBackendClasses This makes it reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/4d3c3b9305134cea61e4d0f37a373f5ea0ae2c82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +29 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Johnni Winther
3 years, 8 months ago (2017-04-07 14:23:07 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-10 19:24:25 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-11 08:14:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d3c3b9305134cea61e4d0f37a373f5ea0ae2c82 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698