Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: runtime/vm/constants_dbc.h

Issue 2799373002: Pass a second type argument vector to all type instantiation calls in the VM. (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/constant_propagator.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/constants_dbc.h
diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h
index 713ec39029cac61107bf9c03cd710aeacb452096..a1c1e312e8e5a0ded58d87bb92ed2d4f27fb9f4e 100644
--- a/runtime/vm/constants_dbc.h
+++ b/runtime/vm/constants_dbc.h
@@ -535,26 +535,30 @@ namespace dart {
//
// - InstantiateType D
//
-// Instantiate type PP[D] with instantiator type arguments SP[0].
+// Instantiate type PP[D] with instantiator type arguments SP[-1] and
+// function type arguments SP[0].
//
// - InstantiateTypeArgumentsTOS D
//
-// Instantiate type arguments PP[D] with instantiator SP[0].
+// Instantiate type arguments PP[D] with instantiator type arguments SP[-1]
+// and function type arguments SP[0].
//
// - InstanceOf
//
-// Test if instance SP[-3] with type arguments SP[-2] is a subtype of SP[-1]
-// using SubtypeTestCache SP[0], with result placed at top of stack.
+// Test if instance SP[-4] with instantiator type arguments SP[-3] and
+// function type arguments SP[-2] is a subtype of type SP[-1] using
+// SubtypeTestCache SP[0], with result placed at top of stack.
//
// - AssertAssignable A, D
//
-// Assert that SP[-3] is assignable to variable named SP[0] of type
-// SP[-1] with type arguments SP[-2] using SubtypeTestCache PP[D].
+// Assert that instance SP[-4] is assignable to variable named SP[0] of
+// type SP[-1] with instantiator type arguments SP[-3] and function type
+// arguments SP[-2] using SubtypeTestCache PP[D].
// If A is 1, then the instance may be a Smi.
//
// - BadTypeError
//
-// If SP[-3] is non-null, throws a BadType error by calling into the runtime.
+// If SP[-4] is non-null, throws a BadType error by calling into the runtime.
// Assumes that the stack is arranged the same as for AssertAssignable.
//
// - AssertBoolean A
« no previous file with comments | « runtime/vm/constant_propagator.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698