runtime/vm/flow_graph_compiler_dbc.cc - Issue 2799373002: Pass a second type argument vector to all type instantiation calls in the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2799373002: Pass a second type argument vector to all type instantiation calls in the VM. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_dbc.cc

diff --git a/runtime/vm/flow_graph_compiler_dbc.cc b/runtime/vm/flow_graph_compiler_dbc.cc

index 5e0f8bce871702bc31336f5531f12c7461e89934..47cfb97c4d0c605ba11660405c98e1837f27ef24 100644

--- a/runtime/vm/flow_graph_compiler_dbc.cc

+++ b/runtime/vm/flow_graph_compiler_dbc.cc

@@ -234,8 +234,9 @@ void FlowGraphCompiler::GenerateAssertAssignable(TokenPosition token_pos,

}

if (is_optimizing()) {

- __ Push(locs->in(0).reg());

- __ Push(locs->in(1).reg());

+ __ Push(locs->in(0).reg()); // Instance.

+ __ Push(locs->in(1).reg()); // Instantiator type arguments.

+ __ Push(locs->in(2).reg()); // Function type arguments.

}

__ PushConstant(dst_type);

__ PushConstant(dst_name);