Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: runtime/vm/flow_graph_inliner.cc

Issue 2799373002: Pass a second type argument vector to all type instantiation calls in the VM. (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 #if !defined(DART_PRECOMPILED_RUNTIME) 4 #if !defined(DART_PRECOMPILED_RUNTIME)
5 #include "vm/flow_graph_inliner.h" 5 #include "vm/flow_graph_inliner.h"
6 6
7 #include "vm/aot_optimizer.h" 7 #include "vm/aot_optimizer.h"
8 #include "vm/precompiler.h" 8 #include "vm/precompiler.h"
9 #include "vm/block_scheduler.h" 9 #include "vm/block_scheduler.h"
10 #include "vm/branch_optimizer.h" 10 #include "vm/branch_optimizer.h"
(...skipping 2413 matching lines...) Expand 10 before | Expand all | Expand 10 after
2424 ASSERT(value_type.IsFloat64x2Type()); 2424 ASSERT(value_type.IsFloat64x2Type());
2425 ASSERT(value_type.IsInstantiated()); 2425 ASSERT(value_type.IsInstantiated());
2426 break; 2426 break;
2427 } 2427 }
2428 default: 2428 default:
2429 // TODO(fschneider): Add support for other array types. 2429 // TODO(fschneider): Add support for other array types.
2430 UNREACHABLE(); 2430 UNREACHABLE();
2431 } 2431 }
2432 AssertAssignableInstr* assert_value = new (Z) AssertAssignableInstr( 2432 AssertAssignableInstr* assert_value = new (Z) AssertAssignableInstr(
2433 token_pos, new (Z) Value(stored_value), new (Z) Value(type_args), 2433 token_pos, new (Z) Value(stored_value), new (Z) Value(type_args),
2434 NULL, // TODO(regis): Pass null value for function type arguments. 2434 new (Z) Value(flow_graph->constant_null()), // Function type arguments.
2435 value_type, Symbols::Value(), call->deopt_id()); 2435 value_type, Symbols::Value(), call->deopt_id());
2436 cursor = flow_graph->AppendTo(cursor, assert_value, call->env(), 2436 cursor = flow_graph->AppendTo(cursor, assert_value, call->env(),
2437 FlowGraph::kValue); 2437 FlowGraph::kValue);
2438 } 2438 }
2439 2439
2440 array_cid = PrepareInlineIndexedOp(flow_graph, call, array_cid, &array, index, 2440 array_cid = PrepareInlineIndexedOp(flow_graph, call, array_cid, &array, index,
2441 &cursor); 2441 &cursor);
2442 2442
2443 // Check if store barrier is needed. Byte arrays don't need a store barrier. 2443 // Check if store barrier is needed. Byte arrays don't need a store barrier.
2444 StoreBarrierType needs_store_barrier = 2444 StoreBarrierType needs_store_barrier =
(...skipping 1387 matching lines...) Expand 10 before | Expand all | Expand 10 after
3832 } 3832 }
3833 3833
3834 default: 3834 default:
3835 return false; 3835 return false;
3836 } 3836 }
3837 } 3837 }
3838 3838
3839 3839
3840 } // namespace dart 3840 } // namespace dart
3841 #endif // !defined(DART_PRECOMPILED_RUNTIME) 3841 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698