Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1516)

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl

Issue 2799363002: Make generated field groups inherit from RefCountedCopyable. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
index dc27cf3ec655466e1f56209ec2131b728597445c..3b62d0a290e0dd5805de69989ddd7a5d7e0daa5d 100644
--- a/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
+++ b/third_party/WebKit/Source/build/scripts/templates/fields/group.tmpl
@@ -1,7 +1,7 @@
{% from 'fields/field.tmpl' import encode, declare_storage %}
{% from 'macros.tmpl' import print_if %}
{% macro define_field_group_class(group): -%}
-class {{group.type_name}} : public RefCounted<{{group.type_name}}> {
+class {{group.type_name}} : public RefCountedCopyable<{{group.type_name}}> {
public:
static PassRefPtr<{{group.type_name}}> Create() {
return AdoptRef(new {{group.type_name}});
@@ -30,11 +30,6 @@ class {{group.type_name}} : public RefCounted<{{group.type_name}}> {
{% endfor %}
{}
- ALWAYS_INLINE {{group.type_name}}(const {{group.type_name}}& other) :
- RefCounted<{{group.type_name}}>(),
- {% for field in group.fields %}
- {{field.name}}(other.{{field.name}}){{print_if(not loop.last, ',')}}
- {% endfor %}
- {}
+ {{group.type_name}}(const {{group.type_name}}&) = default;
};
{%- endmacro %}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698