Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4255)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2799343003: Add support for native extension notifications (Closed)
Patch Set: Remove dependent CL to land standalone Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_mac.mm
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm
index 50a54b6b8a263daae4279f23954de63b0032ed4c..16220a75c19a9843c2aa5e1983a98e7d5204d719 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm
@@ -172,8 +172,12 @@ void NotificationPlatformBridgeMac::Display(
[builder setTitle:base::SysUTF16ToNSString(notification.title())];
[builder setContextMessage:base::SysUTF16ToNSString(notification.message())];
+ bool requires_attribution =
+ notification.context_message().empty() &&
+ notification_type != NotificationCommon::EXTENSION;
+
base::string16 subtitle =
- notification.context_message().empty()
+ requires_attribution
? url_formatter::FormatOriginForSecurityDisplay(
url::Origin(notification.origin_url()),
url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS)
@@ -184,6 +188,8 @@ void NotificationPlatformBridgeMac::Display(
[builder setIcon:notification.icon().ToNSImage()];
}
+ [builder setShowSettingsButton:(notification_type !=
+ NotificationCommon::EXTENSION)];
std::vector<message_center::ButtonInfo> buttons = notification.buttons();
if (!buttons.empty()) {
DCHECK_LE(buttons.size(), blink::kWebNotificationMaxActions);

Powered by Google App Engine
This is Rietveld 408576698