Index: third_party/checkstyle/README.chromium |
diff --git a/third_party/checkstyle/README.chromium b/third_party/checkstyle/README.chromium |
index e84fcf8fe8d5348c87d141c64ec1b6992bf0367d..947034b0884491fc9b4ccc40813359fb07357007 100644 |
--- a/third_party/checkstyle/README.chromium |
+++ b/third_party/checkstyle/README.chromium |
@@ -1,8 +1,8 @@ |
Name: Checkstyle is a development tool to help programmers write Java code that |
adheres to a coding standard. |
Short Name: checkstyle |
-URL: http://checkstyle.sourceforge.net/ |
-Version: 6.5 |
+URL: https://github.com/checkstyle/checkstyle |
+Version: 7.6.1 |
License: LGPL 2.1 |
License File: NOT_SHIPPED |
Security Critical: no |
@@ -11,5 +11,15 @@ Description: |
Checkstyle is used to validate Java code style on Chromium PRESUBMIT step. |
Local Modifications: |
-- Downloaded checkstyle-6.5-all.jar without source code development |
- documentation. |
+None |
+ |
+Update instructions (requires @google.com account): |
+- Download fat jar from https://sourceforge.net/projects/checkstyle/files/checkstyle/ |
+- Modify tools/android/checkstyle/checkstyle.py and verify the new fat jar works |
+- Remove existing SHA1 file |
nyquist
2017/04/07 18:30:28
Nit; is this required, or will the call to upload_
F
2017/04/07 18:37:40
This is required. The script will generate a new S
nyquist
2017/04/07 18:44:26
Doh! Of course! Thanks :-)
|
+- If gcloud auth tokens are not set up, run |
+$ download_from_google_storage --config |
+- Upload new fat jar to gcloud. In third_party/checkstyle, run |
+$ upload_to_google_storage.py -b chromium-android-tools/checkstyle {new_far_jar} |
+- Check in new SHA1 file |
+ |