third_party/checkstyle/README.chromium - Issue 2799303003: Update third_party/checkstyle to 7.6.1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/checkstyle/README.chromium

Issue 2799303003: Update third_party/checkstyle to 7.6.1 (Closed)

Patch Set: Update checkstyle to 7.6.1 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Name: Checkstyle is a development tool to help programmers write Java code that	1 Name: Checkstyle is a development tool to help programmers write Java code that

2 adheres to a coding standard.	2 adheres to a coding standard.

3 Short Name: checkstyle	3 Short Name: checkstyle

4 URL: http://checkstyle.sourceforge.net/	4 URL: http://checkstyle.sourceforge.net/
	nyquist 2017/04/07 00:10:06 Could we update this to https://github.com/checkst Could we update this to https://github.com/checkstyle/checkstyle in fact? F 2017/04/07 18:15:52 Done. Show quoted text On 2017/04/07 00:10:06, nyquist wrote: > Could we update this to https://github.com/checkstyle/checkstyle in fact? Done.
5 Version: 6.5	5 Version: 7.6.1

6 License: LGPL 2.1	6 License: LGPL 2.1

7 License File: NOT_SHIPPED	7 License File: NOT_SHIPPED

8 Security Critical: no	8 Security Critical: no

9	9

10 Description:	10 Description:
	nyquist 2017/04/07 00:10:06 That page you mentioned contains a lot of generic That page you mentioned contains a lot of generic information. I think you can skip the part about creating it, and probably just quickly mention that you need to use your @google.com account for the auth (just mention `download_from_google_storage --config`). Then, the last thing is to in fact update the file, where you could in particular specify the exact command line you need to run. Otherwise developers would have to look in the DEPS-file to find the bucket name, etc. So yeah, I think it would be helpful to write down the full command for update. F 2017/04/07 18:15:52 Done. Show quoted text On 2017/04/07 00:10:06, nyquist wrote: > That page you mentioned contains a lot of generic information. I think you can > skip the part about creating it, and probably just quickly mention that you need > to use your @google.com account for the auth (just mention > `download_from_google_storage --config`). > > Then, the last thing is to in fact update the file, where you could in > particular specify the exact command line you need to run. Otherwise developers > would have to look in the DEPS-file to find the bucket name, etc. > > So yeah, I think it would be helpful to write down the full command for update. Done.
11 Checkstyle is used to validate Java code style on Chromium PRESUBMIT step.	11 Checkstyle is used to validate Java code style on Chromium PRESUBMIT step.

12	12

13 Local Modifications:	13 Local Modifications:

14 - Downloaded checkstyle-6.5-all.jar without source code development	14 - Downloaded checkstyle-7.6.1-all.jar without source code development
	nyquist 2017/04/07 00:10:06 Could you mention that this could be downloaded fr Could you mention that this could be downloaded from: https://github.com/checkstyle/checkstyle/releases ? F 2017/04/07 18:15:52 Done. The fat jar seems to be only available on so Show quoted text On 2017/04/07 00:10:06, nyquist wrote: > Could you mention that this could be downloaded from: > https://github.com/checkstyle/checkstyle/releases ? Done. The fat jar seems to be only available on sourceforge.net
15 documentation.	15 documentation.

OLD	NEW

« no previous file with comments | « third_party/checkstyle/OWNERS ('k') | third_party/checkstyle/checkstyle-6.5-all.jar » ('j') | no next file with comments »