Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: components/favicon/ios/web_favicon_driver.mm

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)
Patch Set: Addressed comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/ios/web_favicon_driver.mm
diff --git a/components/favicon/ios/web_favicon_driver.mm b/components/favicon/ios/web_favicon_driver.mm
index 321acb6c0db486cca99b3bf23e4563e219c82fb6..0025341b75737cccef9a212bc31c5a51ec1d2158 100644
--- a/components/favicon/ios/web_favicon_driver.mm
+++ b/components/favicon/ios/web_favicon_driver.mm
@@ -102,6 +102,11 @@ int WebFaviconDriver::DownloadImage(const GURL& url,
return downloaded_image_count;
}
+void WebFaviconDriver::DownloadManifest(const GURL& url,
+ ManifestDownloadCallback callback) {
+ NOTREACHED();
+}
+
bool WebFaviconDriver::IsOffTheRecord() {
DCHECK(web_state());
return web_state()->GetBrowserState()->IsOffTheRecord();
@@ -141,7 +146,8 @@ WebFaviconDriver::~WebFaviconDriver() {
void WebFaviconDriver::FaviconUrlUpdated(
const std::vector<web::FaviconURL>& candidates) {
DCHECK(!candidates.empty());
- OnUpdateCandidates(GetActiveURL(), FaviconURLsFromWebFaviconURLs(candidates));
+ OnUpdateCandidates(GetActiveURL(), FaviconURLsFromWebFaviconURLs(candidates),
+ GURL());
}
} // namespace favicon

Powered by Google App Engine
This is Rietveld 408576698