components/favicon/content/content_favicon_driver_unittest.cc - Issue 2799273002: Add support to process favicons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/content/content_favicon_driver_unittest.cc

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)

Patch Set: Addressed comments. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/content/content_favicon_driver_unittest.cc

diff --git a/components/favicon/content/content_favicon_driver_unittest.cc b/components/favicon/content/content_favicon_driver_unittest.cc

index 5439aee3d760b81b3c1433a06942024dadb8166d..ea32963de7b58205c99228bba08781d1d073c1a4 100644

--- a/components/favicon/content/content_favicon_driver_unittest.cc

+++ b/components/favicon/content/content_favicon_driver_unittest.cc

@@ -130,7 +130,7 @@ TEST_F(ContentFaviconDriverTest, FaviconUpdateNoLastCommittedEntry) {

->DidUpdateFaviconURL(favicon_urls);

// Test that ContentFaviconDriver ignored the favicon url update.

- EXPECT_TRUE(driver->favicon_urls().empty());

+ EXPECT_FALSE(driver->favicon_urls().has_value());

}

TEST_F(ContentFaviconDriverTest, RecordsHistorgramsForCandidates) {