Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: components/favicon/ios/web_favicon_driver.mm

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)
Patch Set: Addressed comments, improved tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/ios/web_favicon_driver.mm
diff --git a/components/favicon/ios/web_favicon_driver.mm b/components/favicon/ios/web_favicon_driver.mm
index 01f4ff8f62518d0d5ec31952d7f063c36e9fcffb..e84656c075a60f9275a193b361f0a3880e41dd9b 100644
--- a/components/favicon/ios/web_favicon_driver.mm
+++ b/components/favicon/ios/web_favicon_driver.mm
@@ -101,6 +101,11 @@ int WebFaviconDriver::DownloadImage(const GURL& url,
return downloaded_image_count;
}
+void WebFaviconDriver::DownloadManifest(const GURL& url,
+ ManifestDownloadCallback callback) {
+ NOTREACHED();
+}
+
bool WebFaviconDriver::IsOffTheRecord() {
DCHECK(web_state());
return web_state()->GetBrowserState()->IsOffTheRecord();
@@ -140,7 +145,8 @@ WebFaviconDriver::~WebFaviconDriver() {
void WebFaviconDriver::FaviconUrlUpdated(
const std::vector<web::FaviconURL>& candidates) {
DCHECK(!candidates.empty());
- OnUpdateFaviconURL(GetActiveURL(), FaviconURLsFromWebFaviconURLs(candidates));
+ OnUpdateCandidates(GetActiveURL(), FaviconURLsFromWebFaviconURLs(candidates),
+ base::nullopt);
}
} // namespace favicon
« components/favicon/core/favicon_handler.cc ('K') | « components/favicon/ios/web_favicon_driver.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698