Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)
Patch Set: Addressed comments, improved tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/core/favicon_driver_impl.h
diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h
index 2faa6f3fa9b6ba3877168e3f23d2dc2622001caf..e97a394aabb642571eb31c79d4f76dbbc0eba296 100644
--- a/components/favicon/core/favicon_driver_impl.h
+++ b/components/favicon/core/favicon_driver_impl.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/macros.h"
+#include "base/optional.h"
#include "components/favicon/core/favicon_driver.h"
#include "components/favicon/core/favicon_handler.h"
@@ -59,8 +60,9 @@ class FaviconDriverImpl : public FaviconDriver,
void SetFaviconOutOfDateForPage(const GURL& url, bool force_reload);
// Broadcasts new favicon URL candidates to FaviconHandlers.
- void OnUpdateFaviconURL(const GURL& page_url,
- const std::vector<FaviconURL>& candidates);
+ void OnUpdateCandidates(const GURL& page_url,
+ const std::vector<FaviconURL>& candidates,
+ const base::Optional<GURL>& manifest_url);
protected:
history::HistoryService* history_service() { return history_service_; }

Powered by Google App Engine
This is Rietveld 408576698