Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: components/favicon/content/content_favicon_driver.h

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)
Patch Set: Addressed comments, improved tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon/content/content_favicon_driver.h
diff --git a/components/favicon/content/content_favicon_driver.h b/components/favicon/content/content_favicon_driver.h
index 4b1b79b65ada76ce315cccc319af3d49c59b7fc2..47ad224395b86c0d7c419f87fa78bf22a041a8f7 100644
--- a/components/favicon/content/content_favicon_driver.h
+++ b/components/favicon/content/content_favicon_driver.h
@@ -6,6 +6,7 @@
#define COMPONENTS_FAVICON_CONTENT_CONTENT_FAVICON_DRIVER_H_
#include "base/macros.h"
+#include "base/optional.h"
#include "components/favicon/core/favicon_driver_impl.h"
#include "content/public/browser/reload_type.h"
#include "content/public/browser/web_contents_observer.h"
@@ -61,6 +62,8 @@ class ContentFaviconDriver
int DownloadImage(const GURL& url,
int max_image_size,
ImageDownloadCallback callback) override;
+ void DownloadManifest(const GURL& url,
+ ManifestDownloadCallback callback) override;
bool IsOffTheRecord() override;
void OnFaviconUpdated(const GURL& page_url,
FaviconDriverObserver::NotificationIconType icon_type,
@@ -71,6 +74,8 @@ class ContentFaviconDriver
// content::WebContentsObserver implementation.
void DidUpdateFaviconURL(
const std::vector<content::FaviconURL>& candidates) override;
+ // TODO/DONOTSUBMIT(mastiz): Make this 'override'.
+ void DidUpdateManifestURL(const base::Optional<GURL>& manifest_url);
void DidStartNavigation(
content::NavigationHandle* navigation_handle) override;
void DidFinishNavigation(

Powered by Google App Engine
This is Rietveld 408576698