build/android/pylib/results/presentation/template/main.html - Issue 2799153008: Add back buttons and load new 'pages' by calling javascript.

Side by Side Diff: build/android/pylib/results/presentation/template/main.html

Issue 2799153008: Add back buttons and load new 'pages' by calling javascript. (Closed)

Patch Set: remove obsolete functions Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « build/android/pylib/results/presentation/javascript/main_html.js ('k') | build/android/pylib/results/presentation/template/table.html » ('j') | build/android/pylib/results/presentation/test_results_presentation.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">	4 <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">

5 <link rel="stylesheet" href="{{server_url}}/{{bucket}}/css/default.css" type ="text/css">	5 <link rel="stylesheet" href="{{server_url}}/{{bucket}}/css/default.css" type ="text/css">

6 <style>	6 <style>

7 table, th, td {	7 table, th, td {

8 border: 1px solid black;	8 border: 1px solid black;

9 border-collapse: collapse;	9 border-collapse: collapse;

10 }	10 }

(...skipping 26 matching lines...) Expand all Loading...
37 border-color: #000000;	37 border-color: #000000;

38 }	38 }

39 </style>	39 </style>

40 <script type="text/javascript">	40 <script type="text/javascript">

41 {% include "javascript/main_html.js" %}	41 {% include "javascript/main_html.js" %}

42 </script>	42 </script>

43 </head>	43 </head>

44 <body class="interface">	44 <body class="interface">

45 <div class="content">	45 <div class="content">

46 <h2 id="summary-header"></h2>	46 <h2 id="summary-header"></h2>

	47 <a class="back_button" onclick="showSuiteTableOnly();"><b><-- Back</b></br ></br></a>
	mikecase (-- gone --) 2017/04/07 23:57:20 ooooooh, I forgot we will lose the ability to use ooooooh, I forgot we will lose the ability to use browser back button. I think instead of this solution you should just use... history.pushState() and also hook into the window.onpopstate event. https://developer.mozilla.org/en-US/docs/Web/Events/popstate Then you can get the back button working, but it wont actually load a new page, so Google storage website wont give you the authentication error thing. BigBossZhiling 2017/04/10 19:43:51 Done. Show quoted text On 2017/04/07 23:57:20, mikecase wrote: > ooooooh, I forgot we will lose the ability to use browser back button. I think > instead of this solution you should just use... > > history.pushState() and also hook into the window.onpopstate event. > > https://developer.mozilla.org/en-US/docs/Web/Events/popstate > > Then you can get the back button working, but it wont actually load a new page, > so Google storage website wont give you the authentication error thing. Done.
47 {% for tb_value in tb_values %}	48 {% for tb_value in tb_values %}

48 {% include 'template/table.html' %}	49 {% include 'template/table.html' %}

49 {% endfor %}	50 {% endfor %}

50 </div>	51 </div>

51 </br>	52 </br>

	53 <a class="back_button" onclick="showSuiteTableOnly();"><b><-- Back</b></br>< /b></a>

52 <a onclick="reportIssues();"><b>Feedback</b></a>	54 <a onclick="reportIssues();"><b>Feedback</b></a>

53 </body>	55 </body>

54 <script>	56 <script>

55 loadPage();	57 showSuiteTableOnly();

56 // Enable sorting for each column of tables.	58 // Enable sorting for each column of tables.

57 Array.prototype.slice.call(document.getElementsByTagName('th'))	59 Array.prototype.slice.call(document.getElementsByTagName('th'))

58 .forEach(function(head) {	60 .forEach(function(head) {

59 head.addEventListener(	61 head.addEventListener(

60 "click",	62 "click",

61 function() { sortByColumn(head); });	63 function() { sortByColumn(head); });

62 }	64 }

63 );	65 );

64 </script>	66 </script>

65 </html>	67 </html>

OLD	NEW