chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc - Issue 2799143002: Improve profile stats performace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

Issue 2799143002: Improve profile stats performace. (Closed)

Patch Set: Always Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/preferences_chromeos_browsertest.cc ('k') | chrome/browser/prefs/pref_functional_browsertest.cc » ('j') | components/prefs/pref_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

diff --git a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

index 68e086d40919d1fad966f59750d2156233ab4dd3..06200271ec7325590e59bb166a03648c3ec592ba 100644

--- a/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

+++ b/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc

@@ -253,7 +253,7 @@ void ChromeInternalLogSource::PopulateLocalStateSettings(

// Extract the "settings" entry in the local state and serialize back to

// a string.

std::unique_ptr<base::DictionaryValue> local_state =

- g_browser_process->local_state()->GetPreferenceValuesOmitDefaults();

+ g_browser_process->local_state()->GetPreferenceValues(false);

const base::DictionaryValue* local_state_settings = nullptr;

if (!local_state->GetDictionary(kSettingsKey, &local_state_settings)) {

VLOG(1) << "Failed to extract the settings entry from Local State.";