Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2045)

Unified Diff: content/browser/appcache/appcache_url_request_job_unittest.cc

Issue 2799133005: Network traffic annotation added to appcache_update_job. (Closed)
Patch Set: Header added. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_url_request_job_unittest.cc
diff --git a/content/browser/appcache/appcache_url_request_job_unittest.cc b/content/browser/appcache/appcache_url_request_job_unittest.cc
index f29607db47107c979483d21606906cefccae4f40..3a5502798a33b169a321be9f63f52e83009277df 100644
--- a/content/browser/appcache/appcache_url_request_job_unittest.cc
+++ b/content/browser/appcache/appcache_url_request_job_unittest.cc
@@ -30,6 +30,7 @@
#include "net/base/net_errors.h"
#include "net/base/request_priority.h"
#include "net/http/http_response_headers.h"
+#include "net/traffic_annotation/network_traffic_annotation_test_helper.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_error_job.h"
@@ -459,7 +460,8 @@ class AppCacheURLRequestJobTest : public testing::Test {
void Basic() {
AppCacheStorage* storage = service_->storage();
request_ = empty_context_->CreateRequest(GURL("http://blah/"),
- net::DEFAULT_PRIORITY, nullptr);
+ net::DEFAULT_PRIORITY, nullptr,
+ TRAFFIC_ANNOTATION_FOR_TESTS);
// Create an instance and see that it looks as expected.
@@ -483,7 +485,8 @@ class AppCacheURLRequestJobTest : public testing::Test {
void DeliveryOrders() {
AppCacheStorage* storage = service_->storage();
std::unique_ptr<net::URLRequest> request(empty_context_->CreateRequest(
- GURL("http://blah/"), net::DEFAULT_PRIORITY, nullptr));
+ GURL("http://blah/"), net::DEFAULT_PRIORITY, nullptr,
+ TRAFFIC_ANNOTATION_FOR_TESTS));
// Create an instance, give it a delivery order and see that
// it looks as expected.
@@ -529,9 +532,9 @@ class AppCacheURLRequestJobTest : public testing::Test {
base::Unretained(this)));
AppCacheStorage* storage = service_->storage();
- request_ = empty_context_->CreateRequest(GURL("http://blah/"),
- net::DEFAULT_PRIORITY,
- url_request_delegate_.get());
+ request_ = empty_context_->CreateRequest(
+ GURL("http://blah/"), net::DEFAULT_PRIORITY,
+ url_request_delegate_.get(), TRAFFIC_ANNOTATION_FOR_TESTS);
// Set up to create an AppCacheURLRequestJob with orders to deliver
// a network response.
@@ -567,9 +570,9 @@ class AppCacheURLRequestJobTest : public testing::Test {
base::Unretained(this)));
AppCacheStorage* storage = service_->storage();
- request_ = empty_context_->CreateRequest(GURL("http://blah/"),
- net::DEFAULT_PRIORITY,
- url_request_delegate_.get());
+ request_ = empty_context_->CreateRequest(
+ GURL("http://blah/"), net::DEFAULT_PRIORITY,
+ url_request_delegate_.get(), TRAFFIC_ANNOTATION_FOR_TESTS);
// Setup to create an AppCacheURLRequestJob with orders to deliver
// a network response.
@@ -619,9 +622,9 @@ class AppCacheURLRequestJobTest : public testing::Test {
void RequestAppCachedResource(bool start_after_delivery_orders) {
AppCacheStorage* storage = service_->storage();
- request_ = empty_context_->CreateRequest(GURL("http://blah/"),
- net::DEFAULT_PRIORITY,
- url_request_delegate_.get());
+ request_ = empty_context_->CreateRequest(
+ GURL("http://blah/"), net::DEFAULT_PRIORITY,
+ url_request_delegate_.get(), TRAFFIC_ANNOTATION_FOR_TESTS);
// Setup to create an AppCacheURLRequestJob with orders to deliver
// a network response.
@@ -735,9 +738,9 @@ class AppCacheURLRequestJobTest : public testing::Test {
void MakeRangeRequest() {
AppCacheStorage* storage = service_->storage();
- request_ = empty_context_->CreateRequest(GURL("http://blah/"),
- net::DEFAULT_PRIORITY,
- url_request_delegate_.get());
+ request_ = empty_context_->CreateRequest(
+ GURL("http://blah/"), net::DEFAULT_PRIORITY,
+ url_request_delegate_.get(), TRAFFIC_ANNOTATION_FOR_TESTS);
// Request a range, the 3 middle chars out of 'Hello'
net::HttpRequestHeaders extra_headers;

Powered by Google App Engine
This is Rietveld 408576698