Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2799103004: Fix ODR violation for features::kV8NoTurbo in component builds (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ODR violation for features::kV8NoTurbo in component builds features::kV8NoTurbo is defined in //gin:gin_features. Since this is a global and this build target has dependencies from multiple other targets it must be a component instead of a source_set to avoid multiple definitions. As a component it must then also have its own _export.h header. BUG=None Review-Url: https://codereview.chromium.org/2799103004 Cr-Commit-Position: refs/heads/master@{#462494} Committed: https://chromium.googlesource.com/chromium/src/+/86718dcdf2d893bf2940ee5a1353a75cdfcb75e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M gin/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A gin/gin_features_export.h View 1 chunk +29 lines, -0 lines 0 comments Download
M gin/public/gin_features.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 8 months ago (2017-04-05 23:49:22 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-06 09:59:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799103004/1
3 years, 8 months ago (2017-04-06 15:31:09 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 15:50:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/86718dcdf2d893bf2940ee5a1353...

Powered by Google App Engine
This is Rietveld 408576698