chrome/browser/sync/test/integration/two_client_printers_sync_test.cc - Issue 2799103002: Enable printers sync_integration_tests on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

Issue 2799103002: Enable printers sync_integration_tests on chromeos (Closed)

Patch Set: Add comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/test/integration/single_client_printers_sync_test.cc ('K') | « chrome/browser/sync/test/integration/single_client_printers_sync_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

diff --git a/chrome/browser/sync/test/integration/two_client_printers_sync_test.cc b/chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

index 29ea6f0ad839b74b4c9d21db9a117fdca5598f18..96338833df49c594bf8f26f862e9ccc849289b86 100644

--- a/chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

+++ b/chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

@@ -128,13 +128,7 @@ IN_PROC_BROWSER_TEST_F(TwoClientPrintersSyncTest, ConflictResolution) {

EXPECT_EQ(valid_message, GetPrinterStore(1)->GetPrinters()[0]->description());

}

-// crbug.com/689662

-#if defined(OS_CHROMEOS)

-#define MAYBE_SimpleMerge DISABLED_SimpleMerge

-#else

-#define MAYBE_SimpleMerge SimpleMerge

-#endif

-IN_PROC_BROWSER_TEST_F(TwoClientPrintersSyncTest, MAYBE_SimpleMerge) {

+IN_PROC_BROWSER_TEST_F(TwoClientPrintersSyncTest, SimpleMerge) {

ASSERT_TRUE(SetupClients());

base::RunLoop().RunUntilIdle();