Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_printers_sync_test.cc

Issue 2799103002: Enable printers sync_integration_tests on chromeos (Closed)
Patch Set: add todo Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/sync/test/integration/single_client_printers_sync_test.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdio.h> 5 #include <stdio.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "chrome/browser/sync/test/integration/printers_helper.h" 9 #include "chrome/browser/sync/test/integration/printers_helper.h"
10 #include "chrome/browser/sync/test/integration/sync_test.h" 10 #include "chrome/browser/sync/test/integration/sync_test.h"
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 121
122 std::string valid_message = "YAY! More recent changes win!"; 122 std::string valid_message = "YAY! More recent changes win!";
123 ASSERT_TRUE(EditPrinterDescription(GetPrinterStore(0), 0, valid_message)); 123 ASSERT_TRUE(EditPrinterDescription(GetPrinterStore(0), 0, valid_message));
124 124
125 // Conflict resolution shoud run here. 125 // Conflict resolution shoud run here.
126 ASSERT_TRUE(PrintersMatchChecker().Wait()); 126 ASSERT_TRUE(PrintersMatchChecker().Wait());
127 // The more recent update should win. 127 // The more recent update should win.
128 EXPECT_EQ(valid_message, GetPrinterStore(1)->GetPrinters()[0]->description()); 128 EXPECT_EQ(valid_message, GetPrinterStore(1)->GetPrinters()[0]->description());
129 } 129 }
130 130
131 // crbug.com/689662 131 IN_PROC_BROWSER_TEST_F(TwoClientPrintersSyncTest, SimpleMerge) {
132 #if defined(OS_CHROMEOS)
133 #define MAYBE_SimpleMerge DISABLED_SimpleMerge
134 #else
135 #define MAYBE_SimpleMerge SimpleMerge
136 #endif
137 IN_PROC_BROWSER_TEST_F(TwoClientPrintersSyncTest, MAYBE_SimpleMerge) {
138 ASSERT_TRUE(SetupClients()); 132 ASSERT_TRUE(SetupClients());
139 base::RunLoop().RunUntilIdle(); 133 base::RunLoop().RunUntilIdle();
140 134
141 // Store 0 has the even printers 135 // Store 0 has the even printers
142 AddPrinter(GetPrinterStore(0), CreateTestPrinter(0)); 136 AddPrinter(GetPrinterStore(0), CreateTestPrinter(0));
143 AddPrinter(GetPrinterStore(0), CreateTestPrinter(2)); 137 AddPrinter(GetPrinterStore(0), CreateTestPrinter(2));
144 138
145 // Store 1 has the odd printers 139 // Store 1 has the odd printers
146 AddPrinter(GetPrinterStore(1), CreateTestPrinter(1)); 140 AddPrinter(GetPrinterStore(1), CreateTestPrinter(1));
147 AddPrinter(GetPrinterStore(1), CreateTestPrinter(3)); 141 AddPrinter(GetPrinterStore(1), CreateTestPrinter(3));
148 142
149 ASSERT_TRUE(SetupSync()); 143 ASSERT_TRUE(SetupSync());
150 144
151 // Stores should contain the same values now. 145 // Stores should contain the same values now.
152 EXPECT_EQ(4, GetPrinterCount(0)); 146 EXPECT_EQ(4, GetPrinterCount(0));
153 EXPECT_TRUE(AllProfilesContainSamePrinters()); 147 EXPECT_TRUE(AllProfilesContainSamePrinters());
154 } 148 }
155 149
156 } // namespace 150 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/sync/test/integration/single_client_printers_sync_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698