Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2799093007: Issue 29288. When infer new FunctionType, makes its FunctionElement own its ParameterElement(s). (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 29288. When infer new FunctionType, makes its FunctionElement own its ParameterElement(s). Never share. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/29288 Committed: https://github.com/dart-lang/sdk/commit/ee89054fe988f1ecf7bcd997a7c71f8ff840579a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M pkg/analyzer/lib/src/generated/type_system.dart View 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-07 18:42:55 UTC) #1
Brian Wilkerson
lgtm
3 years, 8 months ago (2017-04-07 19:00:42 UTC) #2
scheglov
3 years, 8 months ago (2017-04-07 19:22:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee89054fe988f1ecf7bcd997a7c71f8ff840579a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698