Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: chrome/browser/ui/android/infobars/translate_compact_infobar.cc

Issue 2799083004: Implements ApplyTranslateOptions in compact infobar (Closed)
Patch Set: a Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/infobars/translate_compact_infobar.cc
diff --git a/chrome/browser/ui/android/infobars/translate_compact_infobar.cc b/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
index 2e08dfe5e1d749a7d5bec4dfe63781998416c049..079eeb852de78ae2d5c7e39d541be7d37074a14d 100644
--- a/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
+++ b/chrome/browser/ui/android/infobars/translate_compact_infobar.cc
@@ -80,8 +80,48 @@ void TranslateCompactInfoBar::SetJavaInfoBar(
void TranslateCompactInfoBar::ApplyTranslateOptions(
JNIEnv* env,
- const JavaParamRef<jobject>& obj) {
- // TODO(ramyasharma): Implement.
+ const JavaParamRef<jobject>& obj,
+ int option,
+ const JavaParamRef<jstring>& value) {
+ translate::TranslateInfoBarDelegate* delegate = GetDelegate();
+ if (option == TranslateUtils::OPTION_SOURCE_CODE) {
gone 2017/04/11 17:32:36 These should be else ifs.
ramyasharma 2017/04/12 00:36:41 thanks. done.
+ std::string source_code =
+ base::android::ConvertJavaStringToUTF8(env, value);
+ if (delegate->original_language_code().compare(source_code) != 0)
+ delegate->UpdateOriginalLanguage(source_code);
+ }
+
+ if (option == TranslateUtils::OPTION_TARGET_CODE) {
+ std::string target_code =
+ base::android::ConvertJavaStringToUTF8(env, value);
+ if (delegate->target_language_code().compare(target_code) != 0)
+ delegate->UpdateTargetLanguage(target_code);
+ }
+
+ if (option == TranslateUtils::OPTION_ALWAYS_TRANSLATE) {
+ bool always_translate = GetBoolValue(env, value);
+ if (delegate->ShouldAlwaysTranslate() != always_translate)
+ delegate->ToggleAlwaysTranslate();
+ }
+
+ if (option == TranslateUtils::OPTION_NEVER_TRANSLATE) {
+ bool never_translate = GetBoolValue(env, value);
+ if (never_translate && delegate->IsTranslatableLanguageByPrefs())
+ delegate->ToggleTranslatableLanguageByPrefs();
+ }
+
+ if (option == TranslateUtils::OPTION_NEVER_TRANSLATE_SITE) {
+ bool never_translate_site = GetBoolValue(env, value);
+ if (never_translate_site && !delegate->IsSiteBlacklisted())
+ delegate->ToggleSiteBlacklist();
+ }
+}
+
+bool TranslateCompactInfoBar::GetBoolValue(JNIEnv* env,
+ const JavaParamRef<jstring>& value) {
+ const std::string kTrue = "true";
gone 2017/04/11 17:32:36 you shouldn't be needing this function after chang
ramyasharma 2017/04/12 00:36:40 Moved the const the anonymous namespace. Thanks.
+ std::string string_value = base::android::ConvertJavaStringToUTF8(env, value);
+ return kTrue.compare(string_value) == 0;
}
void TranslateCompactInfoBar::OnPageTranslated(

Powered by Google App Engine
This is Rietveld 408576698