Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/ui/android/infobars/translate_compact_infobar.cc

Issue 2799083004: Implements ApplyTranslateOptions in compact infobar (Closed)
Patch Set: Review comments addressed Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/android/infobars/translate_compact_infobar.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h" 5 #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 } 71 }
72 72
73 void TranslateCompactInfoBar::SetJavaInfoBar( 73 void TranslateCompactInfoBar::SetJavaInfoBar(
74 const base::android::JavaRef<jobject>& java_info_bar) { 74 const base::android::JavaRef<jobject>& java_info_bar) {
75 InfoBarAndroid::SetJavaInfoBar(java_info_bar); 75 InfoBarAndroid::SetJavaInfoBar(java_info_bar);
76 JNIEnv* env = base::android::AttachCurrentThread(); 76 JNIEnv* env = base::android::AttachCurrentThread();
77 Java_TranslateCompactInfoBar_setNativePtr(env, java_info_bar, 77 Java_TranslateCompactInfoBar_setNativePtr(env, java_info_bar,
78 reinterpret_cast<intptr_t>(this)); 78 reinterpret_cast<intptr_t>(this));
79 } 79 }
80 80
81 void TranslateCompactInfoBar::ApplyTranslateOptions( 81 void TranslateCompactInfoBar::ApplyStringTranslateOption(
82 JNIEnv* env, 82 JNIEnv* env,
83 const JavaParamRef<jobject>& obj) { 83 const JavaParamRef<jobject>& obj,
84 // TODO(ramyasharma): Implement. 84 int option,
85 const JavaParamRef<jstring>& value) {
86 translate::TranslateInfoBarDelegate* delegate = GetDelegate();
87 if (option == TranslateUtils::OPTION_SOURCE_CODE) {
88 std::string source_code =
89 base::android::ConvertJavaStringToUTF8(env, value);
90 if (delegate->original_language_code().compare(source_code) != 0)
91 delegate->UpdateOriginalLanguage(source_code);
92 } else if (option == TranslateUtils::OPTION_TARGET_CODE) {
93 std::string target_code =
94 base::android::ConvertJavaStringToUTF8(env, value);
95 if (delegate->target_language_code().compare(target_code) != 0)
96 delegate->UpdateTargetLanguage(target_code);
97 } else {
98 DCHECK(false);
99 }
100 }
101
102 void TranslateCompactInfoBar::ApplyBoolTranslateOption(
103 JNIEnv* env,
104 const JavaParamRef<jobject>& obj,
105 int option,
106 jboolean value) {
107 translate::TranslateInfoBarDelegate* delegate = GetDelegate();
108 if (option == TranslateUtils::OPTION_ALWAYS_TRANSLATE) {
109 if (delegate->ShouldAlwaysTranslate() != value)
110 delegate->ToggleAlwaysTranslate();
111 } else if (option == TranslateUtils::OPTION_NEVER_TRANSLATE) {
112 if (value && delegate->IsTranslatableLanguageByPrefs())
113 delegate->ToggleTranslatableLanguageByPrefs();
114 } else if (option == TranslateUtils::OPTION_NEVER_TRANSLATE_SITE) {
115 if (value && !delegate->IsSiteBlacklisted())
116 delegate->ToggleSiteBlacklist();
117 } else {
118 DCHECK(false);
119 }
85 } 120 }
86 121
87 void TranslateCompactInfoBar::OnPageTranslated( 122 void TranslateCompactInfoBar::OnPageTranslated(
88 const std::string& original_lang, 123 const std::string& original_lang,
89 const std::string& translated_lang, 124 const std::string& translated_lang,
90 translate::TranslateErrors::Type error_type) { 125 translate::TranslateErrors::Type error_type) {
91 if (!owner()) 126 if (!owner())
92 return; // We're closing; don't call anything, it might access the owner. 127 return; // We're closing; don't call anything, it might access the owner.
93 128
94 DCHECK(translate_driver_); 129 DCHECK(translate_driver_);
95 JNIEnv* env = base::android::AttachCurrentThread(); 130 JNIEnv* env = base::android::AttachCurrentThread();
96 Java_TranslateCompactInfoBar_onPageTranslated(env, GetJavaInfoBar(), 131 Java_TranslateCompactInfoBar_onPageTranslated(env, GetJavaInfoBar(),
97 error_type); 132 error_type);
98 } 133 }
99 134
100 translate::TranslateInfoBarDelegate* TranslateCompactInfoBar::GetDelegate() { 135 translate::TranslateInfoBarDelegate* TranslateCompactInfoBar::GetDelegate() {
101 return delegate()->AsTranslateInfoBarDelegate(); 136 return delegate()->AsTranslateInfoBarDelegate();
102 } 137 }
103 138
104 // Native JNI methods --------------------------------------------------------- 139 // Native JNI methods ---------------------------------------------------------
105 140
106 // static 141 // static
107 bool RegisterTranslateCompactInfoBar(JNIEnv* env) { 142 bool RegisterTranslateCompactInfoBar(JNIEnv* env) {
108 return RegisterNativesImpl(env); 143 return RegisterNativesImpl(env);
109 } 144 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/android/infobars/translate_compact_infobar.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698