Implements ApplyTranslateOptions in compact infobar

chrome/browser/ui/android/infobars/translate_compact_infobar.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/infobars/translate_compact_infobar.h"
 
 #include <stddef.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 60 matching lines @@
 }
 
 void TranslateCompactInfoBar::SetJavaInfoBar(
     const base::android::JavaRef<jobject>& java_info_bar) {
   InfoBarAndroid::SetJavaInfoBar(java_info_bar);
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_TranslateCompactInfoBar_setNativePtr(env, java_info_bar,
                                             reinterpret_cast<intptr_t>(this));
 }
 
-void TranslateCompactInfoBar::ApplyTranslateOptions(
+void TranslateCompactInfoBar::ApplyStringTranslateOption(
     JNIEnv* env,
-    const JavaParamRef<jobject>& obj) {
-  // TODO(ramyasharma): Implement.
+    const JavaParamRef<jobject>& obj,
+    int option,
+    const JavaParamRef<jstring>& value) {
+  translate::TranslateInfoBarDelegate* delegate = GetDelegate();
+  if (option == TranslateUtils::OPTION_SOURCE_CODE) {
+    std::string source_code =
+        base::android::ConvertJavaStringToUTF8(env, value);
+    if (delegate->original_language_code().compare(source_code) != 0)
+      delegate->UpdateOriginalLanguage(source_code);
+  } else if (option == TranslateUtils::OPTION_TARGET_CODE) {
+    std::string target_code =
+        base::android::ConvertJavaStringToUTF8(env, value);
+    if (delegate->target_language_code().compare(target_code) != 0)
+      delegate->UpdateTargetLanguage(target_code);
+  } else

[gone, 2017/04/13 04:06:21]

need braces here

[ramyasharma, 2017/04/13 04:13:55]

I totally agree with the braces, but in this file (and others that I have seen),
no braces are added for 1 line blocks. And I was asked to be consistent with
that, in previous reviews. 

Should I still add the braces?

[gone, 2017/04/13 04:16:43]

https://google.github.io/styleguide/cppguide.html#Conditionals

If all the clauses didn't need braces then it's fine, but you're mixing here.

[ramyasharma, 2017/04/13 04:24:47]

ah thanks for clearing that up for me Dan. Done

+    DCHECK(false);
+}
+
+void TranslateCompactInfoBar::ApplyBoolTranslateOption(
+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj,
+    int option,
+    jboolean value) {
+  translate::TranslateInfoBarDelegate* delegate = GetDelegate();
+  if (option == TranslateUtils::OPTION_ALWAYS_TRANSLATE) {
+    if (delegate->ShouldAlwaysTranslate() != value)
+      delegate->ToggleAlwaysTranslate();
+  } else if (option == TranslateUtils::OPTION_NEVER_TRANSLATE) {
+    if (value && delegate->IsTranslatableLanguageByPrefs())
+      delegate->ToggleTranslatableLanguageByPrefs();
+  } else if (option == TranslateUtils::OPTION_NEVER_TRANSLATE_SITE) {
+    if (value && !delegate->IsSiteBlacklisted())
+      delegate->ToggleSiteBlacklist();
+  } else

[gone, 2017/04/13 04:06:21]

ditto

[ramyasharma, 2017/04/13 04:13:55]

Acknowledged.

+    DCHECK(false);
 }
 
 void TranslateCompactInfoBar::OnPageTranslated(
     const std::string& original_lang,
     const std::string& translated_lang,
     translate::TranslateErrors::Type error_type) {
   if (!owner())
     return;  // We're closing; don't call anything, it might access the owner.
 
   DCHECK(translate_driver_);
   JNIEnv* env = base::android::AttachCurrentThread();
   Java_TranslateCompactInfoBar_onPageTranslated(env, GetJavaInfoBar(),
                                                 error_type);
 }
 
 translate::TranslateInfoBarDelegate* TranslateCompactInfoBar::GetDelegate() {
   return delegate()->AsTranslateInfoBarDelegate();
 }
 
 // Native JNI methods ---------------------------------------------------------
 
 // static
 bool RegisterTranslateCompactInfoBar(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }