Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2799063002: Revert "Gracefully handle if loaded dill program has no mainMethod set." (Closed)

Created:
3 years, 8 months ago by Emily Fortuna
Modified:
3 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Gracefully handle if loaded dill program has no mainMethod set." This reverts commit b24e594ebd56d58546350cff69536750a912ebb9. I got an email this broke Dart/Flutter integration??? BUG= Committed: https://github.com/dart-lang/sdk/commit/adce9b982adca3bd65291d88a71a244841d6ef86

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Emily Fortuna
Committed patchset #1 (id:1) manually as adce9b982adca3bd65291d88a71a244841d6ef86 (presubmit successful).
3 years, 8 months ago (2017-04-05 20:03:07 UTC) #2
Emily Fortuna
3 years, 8 months ago (2017-04-05 20:04:00 UTC) #4
Message was sent while issue was closed.
TBR
... wtf?

Powered by Google App Engine
This is Rietveld 408576698