Issue 2799054: Remove the AutoFill enable/disable radio from the Options dialog to the AutoFill dialog

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2799054: Remove the AutoFill enable/disable radio from the Options dialog to the AutoFill dialog (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 11 months ago by dhollowa

Modified:
4 years ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Visibility:
Public.

Description

Remove the AutoFill enable/disable radio from the Options dialog to the AutoFill dialog These changes remove the AutoFill enabled radio buttons from the Preferences dialog and adds a single checkbox to the AutoFill dialog to do same. Preferences.xib changes by removing the radio buttons and moving other controls up. AutoFillDialog.xib adds checkbox to control AutoFill enabled preference. Also, other controls in AutoFillDialg.xib now bind their enabled states to the value of the enabled checkbox. BUG=47435 TEST=AutoFillDialogControllerTest.AutoFillEnabled* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51581

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1305 lines, -419 lines)			Patch
M	chrome/app/nibs/AutoFillDialog.xib	View	16 chunks	+221 lines, -11 lines	0 comments	Download
M	chrome/app/nibs/Preferences.xib	View	84 chunks	+1029 lines, -389 lines	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac.mm	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/preferences_window_controller.mm	View	4 chunks	+0 lines, -18 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages