CrOS: Add success/failure indicators for biod methods with no callback.

chromeos/dbus/biod/biod_client.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_BIOD_BIOD_CLIENT_H_
 #define CHROMEOS_DBUS_BIOD_BIOD_CLIENT_H_
 
 #include <string>
 #include <unordered_map>
 #include <vector>
@@ skipping 77 matching lines @@
                                   const std::string& label,
                                   const ObjectPathCallback& callback) = 0;
 
   // Gets all the records registered with this biometric. |callback| is called
   // with all the object paths of the records with |user_id| after this method
   // succeeds. |user_id| contains the unique identifier for the owner of the
   // biometric.
   virtual void GetRecordsForUser(const std::string& user_id,
                                  const UserRecordsCallback& callback) = 0;
 
-  // Irreversibly destroys all records registered.
-  virtual void DestroyAllRecords() = 0;
+  // Irreversibly destroys all records registered. |callback| is called
+  // asynchronosly with the result.

[Daniel Erat, 2017/04/08 01:13:32]

nit: asynchronously (note 'u', also add below)

[sammiequon, 2017/04/08 01:31:48]

Oh wow, i knew that I would spell that wrong so I looked extra careful and still
made a mistake :S.

+  virtual void DestroyAllRecords(const VoidDBusMethodCallback& callback) = 0;
 
   // Starts the biometric auth session. |callback| is called with the object
   // path of the auth session after the method succeeds.
   virtual void StartAuthSession(const ObjectPathCallback& callback) = 0;
 
   // Requests the type of biometric. |callback| is called with the biometric
   // type after the method succeeds.
   virtual void RequestType(const BiometricTypeCallback& callback) = 0;
 
-  // Cancels the enroll session at |enroll_session_path|.
-  virtual void CancelEnrollSession(
-      const dbus::ObjectPath& enroll_session_path) = 0;
+  // Cancels the enroll session at |enroll_session_path|. |callback| is called
+  // with D-Bus failure if there is a D-Bus error along the way; called with

[Daniel Erat, 2017/04/08 01:13:32]

shorten second sentence here too

[sammiequon, 2017/04/08 01:31:48]

Done.

+  // D-Bus success otherwise.
 

[Daniel Erat, 2017/04/08 01:13:32]

delete blank line after comment

[sammiequon, 2017/04/08 01:31:47]

Done.

-  // Ends the auth session at |auth_session_path|.
-  virtual void EndAuthSession(const dbus::ObjectPath& auth_session_path) = 0;
+  virtual void CancelEnrollSession(const dbus::ObjectPath& enroll_session_path,
+                                   const VoidDBusMethodCallback& callback) = 0;
 
-  // Changes the label of the record at |record_path| to |label|.
+  // Ends the auth session at |auth_session_path|. |callback| is called
+  // asynchronosly with the result.
+  virtual void EndAuthSession(const dbus::ObjectPath& auth_session_path,
+                              const VoidDBusMethodCallback& callback) = 0;
+
+  // Changes the label of the record at |record_path| to |label|. |callback| is
+  // called asynchronosly with the result.
   virtual void SetRecordLabel(const dbus::ObjectPath& record_path,
-                              const std::string& label) = 0;
+                              const std::string& label,
+                              const VoidDBusMethodCallback& callback) = 0;
 
   // Removes the record at |record_path|. This record will no longer be able to
-  // used for authentication.
-  virtual void RemoveRecord(const dbus::ObjectPath& record_path) = 0;
+  // used for authentication. |callback| is asynchronosly with the result.

[Daniel Erat, 2017/04/08 01:13:32]

fix second sentence (missing 'called' after 'is')

[sammiequon, 2017/04/08 01:31:47]

Done.

+  virtual void RemoveRecord(const dbus::ObjectPath& record_path,
+                            const VoidDBusMethodCallback& callback) = 0;
 
   // Requests the label of the record at |record_path|. |callback| is called
   // with the label of the record.
   virtual void RequestRecordLabel(const dbus::ObjectPath& record_path,
                                   const LabelCallback& callback) = 0;
 
   // Creates the instance.
   static BiodClient* Create(DBusClientImplementationType type);
 
  protected:
   friend class BiodClientTest;
 
   // Create() should be used instead.
   BiodClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(BiodClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_BIOD_BIOD_CLIENT_H_