Document the parser's design.

Document the parser's design.

R=johnniwinther@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/af73802a67a73047b4ffbdfbb09ee85b6cb0c6e7

[ahe, 2017-04-06 09:59:19]

ahe@google.com changed reviewers:
+ johnniwinther@google.com, scheglov@google.com

[Johnni Winther, 2017-04-06 13:36:22]

lgtm

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:231: /// We say diet parsing when
skipping parts of a file. Both dart2js and the
"We say diet parsing when skipping" -> "We call it 'diet parsing' when the
parser skips"

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:251: ///     Error: Asynchronous
for-loop can only be used in 'async' or 'async*' methods.
Long line.

[scheglov, 2017-04-06 15:35:35]

LGTM

Thanks. A lot of good info.

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:188: /// The parser is designed
to be flexible and extensible. It's methods are
"Its"

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:232: /// Dart VM has been relying
on this from early on as it allows them to more
"have been"?

[ahe, 2017-04-06 15:52:30]

Thank you!

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:188: /// The parser is designed
to be flexible and extensible. It's methods are
On 2017/04/06 15:35:35, scheglov wrote:
> "Its"

Done.

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:231: /// We say diet parsing when
skipping parts of a file. Both dart2js and the
On 2017/04/06 13:36:22, Johnni Winther wrote:
> "We say diet parsing when skipping" -> "We call it 'diet parsing' when the
> parser skips"

Done.

https://codereview.chromium.org/2799043004/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:232: /// Dart VM has been relying
on this from early on as it allows them to more
On 2017/04/06 15:35:35, scheglov wrote:
> "have been"?

Done.

[ahe, 2017-04-06 15:53:08]

Description was changed from

==========
Document the parser's design.
==========

to

==========
Document the parser's design.

R=johnniwinther@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/af73802a67a73047b4ffbdfbb09ee85b6cb0c6e7
==========

[ahe, 2017-04-06 15:53:09]

Committed patchset #2 (id:20001) manually as
af73802a67a73047b4ffbdfbb09ee85b6cb0c6e7.