Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2838)

Unified Diff: base/trace_event/memory_dump_manager_unittest.cc

Issue 2799023002: memory-infra: Switch to MemoryPeakDetector and simplify MemoryDumpScheduler (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/trace_event/memory_dump_manager_unittest.cc
diff --git a/base/trace_event/memory_dump_manager_unittest.cc b/base/trace_event/memory_dump_manager_unittest.cc
index faae270ee1881b6ab823834b4e88a8681df4a831..71159efce32a3ed5c94617a40f8470ea38d44710 100644
--- a/base/trace_event/memory_dump_manager_unittest.cc
+++ b/base/trace_event/memory_dump_manager_unittest.cc
@@ -244,10 +244,6 @@ class MemoryDumpManagerTest : public testing::Test {
task_runner->PostTask(FROM_HERE, closure);
}
- void PollFastMemoryTotal(uint64_t* memory_total) {
- mdm_->PollFastMemoryTotal(memory_total);
- }
-
protected:
void InitializeMemoryDumpManager(bool is_coordinator) {
mdm_->set_dumper_registrations_ignored_for_testing(true);
@@ -278,8 +274,7 @@ class MemoryDumpManagerTest : public testing::Test {
void DisableTracing() { TraceLog::GetInstance()->SetDisabled(); }
bool IsPeriodicDumpingEnabled() const {
- return MemoryDumpScheduler::GetInstance()
- ->IsPeriodicTimerRunningForTesting();
+ return MemoryDumpScheduler::GetInstance()->IsEnabledForTesting();
}
int GetMaxConsecutiveFailuresCount() const {
@@ -808,7 +803,7 @@ TEST_F(MemoryDumpManagerTest, TestPollingOnDumpThread) {
.Times(Between(0, kPollsToQuit - 1))
.WillRepeatedly(Return());
- MemoryDumpScheduler::SetPollingIntervalForTesting(1);
+ // TODO here MemoryDumpScheduler::SetPollingIntervalForTesting(1);
EnableTracingWithTraceConfig(
TraceConfigMemoryTestUtil::GetTraceConfig_PeakDetectionTrigger(3));

Powered by Google App Engine
This is Rietveld 408576698