Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: components/crash/content/app/crash_reporter_client.h

Issue 2799013002: Monitor crashpad_handler for crashes [sometimes] (Closed)
Patch Set: Address review feedback (scottmg) Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_elf/BUILD.gn ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/content/app/crash_reporter_client.h
diff --git a/components/crash/content/app/crash_reporter_client.h b/components/crash/content/app/crash_reporter_client.h
index ccc30483da621a847c31da2af5cff454d31c98e6..9f69c193dda2a220e9aec3a5d36feac4d15c1641 100644
--- a/components/crash/content/app/crash_reporter_client.h
+++ b/components/crash/content/app/crash_reporter_client.h
@@ -179,6 +179,22 @@ class CrashReporterClient {
virtual bool ShouldEnableBreakpadMicrodumps();
#endif
+#if defined(OS_MACOSX) || defined(OS_WIN)
+ // This method should return true to configure a crash reporter capable of
+ // monitoring itself for its own crashes to do so, even if self-monitoring
+ // would be expensive. "Expensive" self-monitoring dedicates an additional
+ // crash handler process to handle the crashes of the initial crash handler
+ // process.
+ //
+ // In some cases, inexpensive self-monitoring may also be available. When it
+ // is, it may be used when this method returns false. If only expensive
+ // self-monitoring is available, returning false from this function will
+ // prevent the crash handler process from being monitored for crashes at all.
+ //
+ // The default implementation returns false.
+ virtual bool ShouldMonitorCrashHandlerExpensively();
+#endif
+
// Returns true if breakpad should run in the given process type.
virtual bool EnableBreakpadForProcess(const std::string& process_type);
};
« no previous file with comments | « chrome_elf/BUILD.gn ('k') | components/crash/content/app/crash_reporter_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698