Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: chrome/browser/ui/extensions/extension_install_ui_default.cc

Issue 2799003002: Unpack theme data from extensions off of UI thread. (Closed)
Patch Set: fix gtk case Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_install_ui_default.cc
diff --git a/chrome/browser/ui/extensions/extension_install_ui_default.cc b/chrome/browser/ui/extensions/extension_install_ui_default.cc
index 53fda5bfd178ad6bf4d24f4e8e41487218a335db..6114b113c8d0058ff9122c413c29375f2b17d411 100644
--- a/chrome/browser/ui/extensions/extension_install_ui_default.cc
+++ b/chrome/browser/ui/extensions/extension_install_ui_default.cc
@@ -9,7 +9,6 @@
#include "base/strings/utf_string_conversions.h"
#include "build/build_config.h"
#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/extensions/theme_installed_infobar_delegate.h"
#include "chrome/browser/infobars/infobar_service.h"
#include "chrome/browser/prefs/incognito_mode_prefs.h"
#include "chrome/browser/profiles/profile.h"
@@ -141,25 +140,13 @@ ExtensionInstallUIDefault::ExtensionInstallUIDefault(
content::BrowserContext* context)
: profile_(Profile::FromBrowserContext(context)),
skip_post_install_ui_(false),
- previous_using_system_theme_(false),
- use_app_installed_bubble_(false) {
- // |profile| can be NULL during tests.
- if (profile_) {
- // Remember the current theme in case the user presses undo.
- const Extension* previous_theme =
- ThemeServiceFactory::GetThemeForProfile(profile_);
- if (previous_theme)
- previous_theme_id_ = previous_theme->id();
- previous_using_system_theme_ =
- ThemeServiceFactory::GetForProfile(profile_)->UsingSystemTheme();
- }
-}
+ use_app_installed_bubble_(false) {}
ExtensionInstallUIDefault::~ExtensionInstallUIDefault() {}
void ExtensionInstallUIDefault::OnInstallSuccess(const Extension* extension,
const SkBitmap* icon) {
- if (skip_post_install_ui_)
+ if (skip_post_install_ui_ || extension->is_theme())
return;
if (!profile_) {
@@ -169,12 +156,6 @@ void ExtensionInstallUIDefault::OnInstallSuccess(const Extension* extension,
return;
}
- if (extension->is_theme()) {
- ThemeInstalledInfoBarDelegate::Create(
- extension, profile_, previous_theme_id_, previous_using_system_theme_);
- return;
- }
-
// Extensions aren't enabled by default in incognito so we confirm
// the install in a normal window.
Profile* current_profile = profile_->GetOriginalProfile();

Powered by Google App Engine
This is Rietveld 408576698