Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: chrome/browser/extensions/theme_installed_infobar_delegate.cc

Issue 2799003002: Unpack theme data from extensions off of UI thread. (Closed)
Patch Set: fix BrowserThemePackUnittest: data race and shutdown sequence Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/theme_installed_infobar_delegate.cc
diff --git a/chrome/browser/extensions/theme_installed_infobar_delegate.cc b/chrome/browser/extensions/theme_installed_infobar_delegate.cc
index 9451f233adbe03ce0ca465557b43ea9285b2d5d9..57d9b8d2808123c9a4f064b72fe17c5736c95ef4 100644
--- a/chrome/browser/extensions/theme_installed_infobar_delegate.cc
+++ b/chrome/browser/extensions/theme_installed_infobar_delegate.cc
@@ -145,7 +145,9 @@ bool ThemeInstalledInfoBarDelegate::Cancel() {
const extensions::Extension* previous_theme =
extension_service_->GetExtensionById(previous_theme_id_, true);
if (previous_theme) {
- theme_service_->SetTheme(previous_theme);
+ theme_service_->RevertToTheme(previous_theme);
+ // TODO(estade): while we're waiting to close, it would be nice to
+ // indicate that the theme is busy reverting.
return false; // The theme change will close us.
}
}

Powered by Google App Engine
This is Rietveld 408576698