chrome/browser/ui/extensions/extension_install_ui_default.h - Issue 2799003002: Unpack theme data from extensions off of UI thread.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/extensions/extension_install_ui_default.h

Issue 2799003002: Unpack theme data from extensions off of UI thread. (Closed)

Patch Set: fix gtk case Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/themes/theme_service_unittest.cc ('k') | chrome/browser/ui/extensions/extension_install_ui_default.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_DEFAULT_H_	5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_DEFAULT_H_

6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_DEFAULT_H_	6 #define CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_DEFAULT_H_

7	7

8 #include "base/compiler_specific.h"	8 #include "base/compiler_specific.h"

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "extensions/browser/install/extension_install_ui.h"	10 #include "extensions/browser/install/extension_install_ui.h"

(...skipping 17 matching lines...) Expand all Loading...
28 void OpenAppInstalledUI(const std::string& app_id) override;	28 void OpenAppInstalledUI(const std::string& app_id) override;

29 void SetSkipPostInstallUI(bool skip_ui) override;	29 void SetSkipPostInstallUI(bool skip_ui) override;

30 gfx::NativeWindow GetDefaultInstallDialogParent() override;	30 gfx::NativeWindow GetDefaultInstallDialogParent() override;

31	31

32 private:	32 private:

33 Profile* profile_;	33 Profile* profile_;

34	34

35 // Whether or not to show the default UI after completing the installation.	35 // Whether or not to show the default UI after completing the installation.

36 bool skip_post_install_ui_;	36 bool skip_post_install_ui_;

37	37

38 // Used to undo theme installation.

39 std::string previous_theme_id_;

40 bool previous_using_system_theme_;

41

42 // Whether to show an installed bubble on app install, or use the default	38 // Whether to show an installed bubble on app install, or use the default

43 // action of opening a new tab page.	39 // action of opening a new tab page.

44 bool use_app_installed_bubble_;	40 bool use_app_installed_bubble_;

45	41

46 DISALLOW_COPY_AND_ASSIGN(ExtensionInstallUIDefault);	42 DISALLOW_COPY_AND_ASSIGN(ExtensionInstallUIDefault);

47 };	43 };

48	44

49 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_DEFAULT_H_	45 #endif // CHROME_BROWSER_UI_EXTENSIONS_EXTENSION_INSTALL_UI_DEFAULT_H_

OLD	NEW