Unpack theme data from extensions off of UI thread.

chrome/browser/ui/extensions/extension_install_ui_default.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/extension_install_ui_default.h"
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/extensions/theme_installed_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/prefs/incognito_mode_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/browser_navigator_params.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
@@ skipping 112 matching lines @@
 GURL ErrorInfoBarDelegate::GetLinkURL() const {
   return GURL("https://support.google.com/chrome_webstore/?p=crx_warning");
 }
 
 }  // namespace
 
 ExtensionInstallUIDefault::ExtensionInstallUIDefault(
     content::BrowserContext* context)
     : profile_(Profile::FromBrowserContext(context)),
       skip_post_install_ui_(false),
-      previous_using_system_theme_(false),
-      use_app_installed_bubble_(false) {
-  // |profile| can be NULL during tests.
-  if (profile_) {
-    // Remember the current theme in case the user presses undo.
-    const Extension* previous_theme =
-        ThemeServiceFactory::GetThemeForProfile(profile_);
-    if (previous_theme)
-      previous_theme_id_ = previous_theme->id();
-    previous_using_system_theme_ =
-        ThemeServiceFactory::GetForProfile(profile_)->UsingSystemTheme();
-  }
-}
+      use_app_installed_bubble_(false) {}
 
 ExtensionInstallUIDefault::~ExtensionInstallUIDefault() {}
 
 void ExtensionInstallUIDefault::OnInstallSuccess(const Extension* extension,
                                                  const SkBitmap* icon) {
-  if (skip_post_install_ui_)
+  if (skip_post_install_ui_ || extension->is_theme())
     return;
 
   if (!profile_) {
     // TODO(zelidrag): Figure out what exact conditions cause crash
     // http://crbug.com/159437 and write browser test to cover it.
     NOTREACHED();
     return;
   }
 
-  if (extension->is_theme()) {
-    ThemeInstalledInfoBarDelegate::Create(

[Devlin, 2017/06/01 00:28:09]

Does moving this out of here and into ThemeService::OnThemeBuiltFromExtension()
result in the infobar being shown significantly later?  I think this method was
called prior to the theme initialization work, which meant there was some
instant UI feedback (though as the CL description notes, that feedback was a
little strange).  Is that correct?  If so, would it be worth keeping the bar
showing early?

[Evan Stade, 2017/06/01 17:43:02]

Before, the browser would immediately hang for a second or two, then when it
resumes functioning, the theme is present and the infobar is showing.

Now, the browser continues to work normally for a second or two, then the theme
and infobar show up after the unpacking delay.

The latter seems strictly preferable. Hanging as a means of "instant feedback"
doesn't seem like a win. :) I did not want to move the infobar's appearance to
before the theme actually installed because then you can press undo and nothing
happens.

[Devlin, 2017/06/01 18:19:58]

Okay, cool.  My concern was if before the flow was:
Click install
Infobar shows
Browser hangs

and now it would be
click install
<second gap>
infobar shows

If the flow was
click install
browser hangs
infobar shows

Then yes, this is definitely better. :)  I do still like your suggestion from
the CL description about showing the infobar sooner with some kind of status;
can we file a bug for that (or add it to the existing one)?

-        extension, profile_, previous_theme_id_, previous_using_system_theme_);
-    return;
-  }
-
   // Extensions aren't enabled by default in incognito so we confirm
   // the install in a normal window.
   Profile* current_profile = profile_->GetOriginalProfile();
   if (extension->is_app()) {
     bool use_bubble = false;
 
 #if defined(TOOLKIT_VIEWS)  || defined(OS_MACOSX)
     use_bubble = use_app_installed_bubble_;
 #endif
 
@@ skipping 61 matching lines @@
 
 gfx::NativeWindow ExtensionInstallUIDefault::GetDefaultInstallDialogParent() {
   Browser* browser = chrome::FindLastActiveWithProfile(profile_);
   if (browser) {
     content::WebContents* contents =
         browser->tab_strip_model()->GetActiveWebContents();
     return contents->GetTopLevelNativeWindow();
   }
   return NULL;
 }