Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

Issue 2798983002: Introduce subresource_filter::Configuration. (Closed)
Patch Set: Rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
index f1b2b5105c669399762b0a3ed293380be0172368..7577274e45f77a54e02a31cd4dcea1a74e67f0c9 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h
@@ -17,6 +17,7 @@
#include "base/time/time.h"
#include "components/safe_browsing_db/util.h"
#include "components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h"
+#include "components/subresource_filter/core/browser/subresource_filter_features.h"
#include "components/subresource_filter/core/common/document_load_statistics.h"
#include "content/public/browser/web_contents_observer.h"
#include "ui/base/page_transition_types.h"
@@ -127,6 +128,14 @@ class ContentSubresourceFilterDriverFactory
return throttle_manager_.get();
}
+ // TODO(https://crbug.com/708181): Allow tests to change the configuration
+ // after construction (which happens at WebContents creation) but before a
+ // navigation start. Can be removed once the Safe Browsing navigation throttle
+ // handles all activation decisions.
+ void set_configuration_for_testing(Configuration configuration) {
+ configuration_ = std::move(configuration);
+ }
+
private:
friend class ContentSubresourceFilterDriverFactoryTest;
friend class safe_browsing::SafeBrowsingServiceTest;
@@ -163,6 +172,8 @@ class ContentSubresourceFilterDriverFactory
void RecordRedirectChainMatchPatternForList(
ActivationList activation_list) const;
+ Configuration configuration_;
+
std::unique_ptr<SubresourceFilterClient> client_;
std::unique_ptr<ContentSubresourceFilterThrottleManager> throttle_manager_;

Powered by Google App Engine
This is Rietveld 408576698