Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: components/sync/js/sync_js_controller_unittest.cc

Issue 2798963003: Use ScopedTaskEnvironment instead of MessageLoop in components unit tests. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine_impl/sync_manager_impl_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/js/sync_js_controller_unittest.cc
diff --git a/components/sync/js/sync_js_controller_unittest.cc b/components/sync/js/sync_js_controller_unittest.cc
index 51622c09f2e934c6177fe21195bc9f57239128d9..a96c92d58b7be776b5acbcbe02955bd274b160e0 100644
--- a/components/sync/js/sync_js_controller_unittest.cc
+++ b/components/sync/js/sync_js_controller_unittest.cc
@@ -5,6 +5,7 @@
#include "components/sync/js/sync_js_controller.h"
#include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
#include "base/values.h"
#include "components/sync/js/js_event_details.h"
#include "components/sync/js/js_test_util.h"
@@ -24,7 +25,7 @@ class SyncJsControllerTest : public testing::Test {
void PumpLoop() { base::RunLoop().RunUntilIdle(); }
private:
- base::MessageLoop message_loop_;
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
};
TEST_F(SyncJsControllerTest, Events) {
« no previous file with comments | « components/sync/engine_impl/sync_manager_impl_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698