components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc - Issue 2798963003: Use ScopedTaskEnvironment instead of MessageLoop in components unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc

Issue 2798963003: Use ScopedTaskEnvironment instead of MessageLoop in components unit tests. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync/engine_impl/js_sync_manager_observer_unittest.cc ('k') | components/sync/engine_impl/sync_manager_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc

diff --git a/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc b/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc

index 3abb3e1baaa3a876d7e6c517a607bef03be680ba..237bd20c583028133913d649e8609f56e67d9731 100644

--- a/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc

+++ b/components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc

@@ -12,6 +12,7 @@

#include "base/json/json_string_value_serializer.h"

#include "base/memory/ptr_util.h"

#include "base/run_loop.h"

+#include "base/test/scoped_task_environment.h"

#include "base/tracked_objects.h"

#include "components/sync/base/fake_encryptor.h"

#include "components/sync/base/model_type_test_util.h"

@@ -357,7 +358,7 @@ class SyncEncryptionHandlerImplTest : public ::testing::Test {

std::unique_ptr<SyncEncryptionHandlerImpl> encryption_handler_;

StrictMock<SyncEncryptionHandlerObserverMock> observer_;

TestIdFactory ids_;

- base::MessageLoop message_loop_;

+ base::test::ScopedTaskEnvironment scoped_task_environment_;

};

// Verify that the encrypted types are being written to and read from the