chrome/browser/page_load_metrics/page_load_metrics_initialize.cc - Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

index 093a74a4beea8b68448b552e4cd228a74724bc02..19e9a9f30ad8ff88ebe75e454f8aa84f98c9b11b 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

@@ -11,6 +11,7 @@

#include "chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.h"

#endif // OS_ANDROID

#include "chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h"

+#include "chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h"

#include "chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.h"

@@ -94,6 +95,10 @@ void PageLoadMetricsEmbedder::RegisterObservers(

tracker->AddObserver(base::MakeUnique<CssScanningMetricsObserver>());

tracker->AddObserver(base::MakeUnique<ProtocolPageLoadMetricsObserver>());

tracker->AddObserver(base::MakeUnique<TabRestorePageLoadMetricsObserver>());

+ std::unique_ptr<AdsPageLoadMetricsObserver> ads_observer =

+ AdsPageLoadMetricsObserver::CreateIfNeeded();

+ if (ads_observer)

+ tracker->AddObserver(std::move(ads_observer));

std::unique_ptr<page_load_metrics::PageLoadMetricsObserver> ukm_observer =

UkmPageLoadMetricsObserver::CreateIfNeeded(web_contents_);