chrome/browser/page_load_metrics/metrics_web_contents_observer.h - Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)

Patch Set: Address comments from PS22 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.h

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

index 9b14bef9e1d04f7f85e3784e421422fc3b0dc93e..f94c7afc171871e5f73a10383f389a7fcdd34e28 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.h

@@ -84,6 +84,8 @@ class MetricsWebContentsObserver

// A resource request completed on the IO thread. This method is invoked on

// the UI thread.

void OnRequestComplete(

+ const GURL& url,

+ int frame_tree_node_id,

const content::GlobalRequestID& request_id,

content::ResourceType resource_type,

bool was_cached,