Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Address comments from PS17 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
index 3d222d7722c7e970d729478e0e3e617bc27e836b..f468bb3a3915cad5111d49a254cdee6580111487 100644
--- a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
@@ -153,10 +153,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, Basic) {
TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
NavigateAndCommit(GURL(kDefaultTestUrl));
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 40 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 40 /* raw_body_bytes */, 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
page_load_metrics::PageLoadTiming timing;
timing.navigation_start = base::Time::FromDoubleT(1);
@@ -165,12 +165,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, Subresources) {
blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
SimulateTimingAndMetadataUpdate(timing, metadata);
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
- SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
+ SimulateLoadedResource({GURL(), -1 /* frame_tree_node_id */,
+ true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */});
@@ -248,10 +249,10 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
SimulateMediaPlayed();
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 40 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 40 /* raw_body_bytes */, 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
page_load_metrics::PageLoadTiming timing;
timing.navigation_start = base::Time::FromDoubleT(1);
@@ -260,12 +261,13 @@ TEST_F(SubresourceFilterMetricsObserverTest, SubresourcesWithMedia) {
blink::WebLoadingBehaviorFlag::kWebLoadingBehaviorSubresourceFilterMatch;
SimulateTimingAndMetadataUpdate(timing, metadata);
- SimulateLoadedResource({false /* was_cached */,
- 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
- nullptr /* data_reduction_proxy_data */});
+ SimulateLoadedResource(
+ {GURL(), -1 /* frame_tree_node_id */, false /* was_cached */,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
+ nullptr /* data_reduction_proxy_data */});
- SimulateLoadedResource({true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
+ SimulateLoadedResource({GURL(), -1 /* frame_tree_node_id */,
+ true /* was_cached */, 1024 * 10 /* raw_body_bytes */,
0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */});

Powered by Google App Engine
This is Rietveld 408576698