Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3284)

Unified Diff: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Address comments from PS17 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
index fbaeae308b1da01dbbdfd7914648a8a273d49018..49ebb7572217d67edf853b245f183e8a652ded9b 100644
--- a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
@@ -419,8 +419,12 @@ TEST_F(DataReductionProxyMetricsObserverTest, OnCompletePingback) {
// Verify LoFi is tracked when a LoFi response is received.
page_load_metrics::ExtraRequestInfo resource = {
- true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- 0 /* original_network_content_length */, std::move(data)};
+ GURL(),
+ -1 /* frame_tree_node_id */,
+ true /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
+ 0 /* original_network_content_length */,
+ std::move(data)};
RunTest(true, false);
SimulateLoadedResource(resource);
@@ -455,18 +459,21 @@ TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationCompression) {
// Prepare 4 resources of varying size and configurations.
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached proxied request with .1 compression ratio.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 * 10 /* original_network_content_length */, data->DeepCopy()},
// Uncached proxied request with .5 compression ratio.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 * 5 /* original_network_content_length */, std::move(data)},
};
@@ -507,18 +514,21 @@ TEST_F(DataReductionProxyMetricsObserverTest, ByteInformationInflation) {
// Prepare 4 resources of varying size and configurations.
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached proxied request with .1 compression ratio.
- {false /*was_cached*/, 1024 * 40 * 10 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 * 10 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */, data->DeepCopy()},
// Uncached proxied request with .5 compression ratio.
- {false /*was_cached*/, 1024 * 40 * 5 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 * 5 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */, std::move(data)},
};

Powered by Google App Engine
This is Rietveld 408576698