Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1751)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Clean up test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index db9a01caa0f514dc732175b0aacdafec18503b12..e3c0910b45fffcc2a4bae4678d970a0d1a06ed1f 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -417,11 +417,12 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
};
@@ -503,11 +504,12 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
};
@@ -583,11 +585,12 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- 0 /* original_network_content_length */,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, 0 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */,
1024 * 40 /* original_network_content_length */,
nullptr /* data_reduction_proxy_data */},
};

Powered by Google App Engine
This is Rietveld 408576698